[TIMOB-23665] Make sure custom classes will be added to Xcode Project #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metabase.classes property will be undefined when not using system frameworks like UIKit. This will result in an exception during the metabase generation of custom swift source files. To prevent this exception, this fix initializes the property to an empty object if it is not already set.
Third party libraries or custom classes won't have an entry in the nativeModules variable. To still update the Xcode project when no other system frameworks are used, we need to explicitly check for them before opting out of updating the project.
|
CR AND FT PASSED. APPROVED! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23665
This PR contains two fixes for issues where using custom classes without any other system framework would result in exceptions. See the commit messages for detailed explanation for each issue.