[TIMOB-23526] Add compatibility with CocoaPods 1.0.0 #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| util.logger.trace('found pod at ' +pod); | ||
| util.logger.trace('found pod ' + version + ' at ' + pod); | ||
| if (semver.lt(version, '1.0.0')) { | ||
| util.logger.info('Using a CocoaPods version below 1.0.0 is deprecated. Please update your CocoaPods installation.'); |
There was a problem hiding this comment.
Can you add a short install-instruction e.g. gem install cocoapods?
|
Left a view clarification-comments. Please also bump to 1.2.6 so we can use that for GA next week, together with #46. |
|
Good points! Added the update instruction, Podfile validation and bumped the version. |
|
LGTM. Will do the FT tomorrow, update hyperloop-examples and draft the new release. /cc @cheekiatng |
|
CR & FT approved! Please do a 1_2_X as well to include it into 5_4_X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23526
This adds compatibility with CocoaPods versions 1.0.0 and above while maintaining full backwards compatibility with 0.39.0.