[TIMOB-23812] Handle class properties correctly #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is out of sync with the 1_2_X backport. Please ensure all commits are integrated in both PR's. |
|
@cheekiatng commented on the jira ticket the special property handling will be removed for 2.0.0. Should i still add the the workaround? |
|
@janvennemann Hans has reminded me, a better approach to this is that it should be implemented the same way as the 1_2_X back port. And create a separate improvement ticket, titled "Better way to generate properties" or something like that. then a new pull request addressing this new ticket to remove the special property handling, with fixVersion "Release 6.0.0". This way it's much easier to backtrack and keep track of all changes. Thanks for the trouble! |
More of a hacky workaround to maintain api compatibility for all methods that were replaced with properties in iOS 10. This checks against a predefined list of properties and based on that, decides wether a js property or method should be generated.
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23812
Adds correct handling for new class level properties introduced with Xcode 8