[TIMOB-23926] Improve Ti SDK handling during CI builds #75
Conversation
| @@ -132,26 +132,60 @@ function extract(filename, installLocation, keepFiles, callback) { | |||
| } | |||
|
|
|||
| /** | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Looks like a merge-error. Please revisit the whole PR and retest ist before submitting to review.
There was a problem hiding this comment.
Already addressed that but the push didn't make it due to github's infamous operation timeout. It's pushed now ;)
| console.log(('Checking for updated Ti SDK from ' + branch).green); | ||
| var args = ['sdk', 'install', '-b', branch, '-d', '--no-banner'], | ||
| prc; | ||
| function installAndSelectLatestTiSDK(branch, next) { |
There was a problem hiding this comment.
Not sure if I like different signatures between versions, but I guess you only have the 5_5_X check for this one release.
There was a problem hiding this comment.
Yeah, the master build script is already different anyway as it now uses commander and allows selecting the branch which causes the different method signature. This makes it more flexible for future releases and i don't think we need to backport that to 1.2.X.
|
Approved! |
JIRA: https://jira.appcelerator.org/browse/TIMOB-23926
Makes sure the correct Ti SDK gets selected before starting the actual build and reselects the previous one after the build finishes.