[TIMOB-2953] Hyperloop fails to cast Ti Intent to native Android Intent #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- try to special case IntentProxy/Intent and ActivityProxy/Activity for method calls/constructors so that we can unwrap the titanium proxies to the native classes, or can accept titanium or native versions for any method expecting titanium or native versions. - Workaround for when creation dictionary for Titanium intent isn't passed, so Intent is null.
sgtcoolguy
force-pushed
the
TIMOB-23953
branch
from
4830a63
to
7efc533
Compare
|
To test: var Intent = require('android.content.Intent');
var intent = Ti.Android.createIntent();
var nativeIntent = new Intent(intent); // Used to fail
Ti.API.info("worked!");Note that I needed to add a special hack for the use case when you provide no creation dictionary to createIntent(), it never generates an internal Intent object, so unwrapping we get a null object and the cast resulted in a NullPointerException. I now explicitly check for null and if null, force a call to handleCreationDict and then re-get the wrapped Intent. |
|
Approved! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-23953
try to special case IntentProxy/Intent and ActivityProxy/Activity for method calls/constructors so that we can unwrap the titanium proxies to the native classes, or can accept titanium or native versions for any method expecting titanium or native versions.