[TIMOB-23911] Remove special property handling #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We introduced a workaround in Hyperloop 1.2.7 to remain backwards compatible with certain properties when transitioning from iOS 9 to iOS 10. This allowed users to keep using methods instead of having to refactor their code to property usage. With Hyperloop 2.0.0 we introduce this as a breaking change and stick to the new favored way of using properties, e.g. UIColor.redColor instead of UIColor.redColor().
|
CR & FT passed, PR approved! Tested using the hyperloop-examples repo and made a PR for the |
This was referenced Oct 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23911
We introduced a workaround in Hyperloop 1.2.7 to remain backwards
compatible with certain properties when transitioning from iOS 9 to
iOS 10. This allowed users to keep using methods instead of having
to refactor their code to property usage. With Hyperloop 2.0.0 we
introduce this as a breaking change and stick to the new favored way
of using properties, e.g. UIColor.redColor instead of
UIColor.redColor().