Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-23971] Hyperloop: iOS not working in 2.0.0 (regression) #83

Merged
merged 2 commits into from Oct 7, 2016

Conversation

sgtcoolguy
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-23971

  • Use correct absolute require paths in generated files now that require behavior is spec-compliant

- Use correct absolute require paths in generated files now that require behavior is spec-compliant
@sgtcoolguy
Copy link
Contributor Author

sgtcoolguy commented Oct 6, 2016

So, turns out the new require behavior was the problem here. We generated requires like:

require('hyperloop/framework/type.js');

That should have continued to work with the new require logic, but apparently does not. Changing to ensure we used requires like so fixed the issue:

require('/hyperloop/framework/type.js');

The latter is correct, but the fact that the old legacy style is broken in SDK 6+ is disconcerting. I'll see if I can look into why it was failing because we'd like to avoid breaking backwards compatibility for similar cases for users...

Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, any Hyperloop require works as expected again!

@hansemannn
Copy link
Contributor

PR approved! But as @sgtcoolguy mentioned, we should retain backwards-compatibility regarding all require use-cases and add a unit-test for it (as we already do for many more :-). Thx!

@hansemannn hansemannn merged commit 0e7ce29 into tidev:master Oct 7, 2016
@sgtcoolguy sgtcoolguy deleted the TIMOB-23971 branch October 7, 2016 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants