[TIMOB-20602] Hyperloop: Build doesn't work with 5.4.0 #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,12 +136,11 @@ HyperloopiOSBuilder.prototype.validate = function validate() { | |||
| process.exit(1); | |||
| } | |||
|
|
|||
| // check for the run-on-main-thread configuration | |||
| if (!this.builder.tiapp.ios['run-on-main-thread']) { | |||
| if (!(this.builder.tiapp.properties && this.builder.tiapp.properties.hasOwnProperty('run-on-main-thread') && this.builder.tiapp.properties['run-on-main-thread'].value))) { | |||
There was a problem hiding this comment.
))) One bracket too much, the build crashes. Also, does this.builder.tiapp.properties['run-on-main-thread'].value catch the false value as well?
There was a problem hiding this comment.
Good catch! the value is either true or false so ya.
|
Tested using the hyperloop-examples app. The app crashes after booting and the error looks metabase related. Works fine with 1.1.1. |
|
Do you have the details of the crash? did you test with the latest PR on titanium_mobile master? Because I know that has not been merged yet and this PR is dependent on that. |
| @@ -986,7 +986,7 @@ HyperloopiOSBuilder.prototype.hookXcodebuild = function hookXcodebuild(data) { | |||
| }); | |||
| } | |||
|
|
|||
| addParam('GCC_PREPROCESSOR_DEFINITIONS', 'HYPERLOOP=1'); | |||
| addParam('GCC_PREPROCESSOR_DEFINITIONS', '$(inherited) HYPERLOOP=1'); | |||
|
CR & FT passed, PR approved! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-20602