fix: add executable information to simulator when looping over xcodes #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding the global simulator runtimes into the runtime info, set the executable information only when we have it and we know the xcode version and simulator are compatible Fixes TIMOB-27490
ssjsamir
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
FR Passed: Able to once again build on iOS Sims using the instructions mentioned in: https://jira.appcelerator.org/browse/TIMOB-27490. This also seemed to fix:(https://jira.appcelerator.org/browse/CLI-1372).
Test Environment
Xcode 11 and 10.2
iOS 13 sim (iPhone 7)
SDK version 8.2.1.v20191021132318
Mac OS X 10.15.1
Node.js Version = 10.16.3
npm Version = 6.9.0
Appcelerator CLI
Installer = 4.2.15-1
Core Package = 7.1.1
cb1kenobi
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding the global simulator runtimes into the runtime info, set the executable information only when we have it and we know the xcode version and simulator are compatible
Fixes TIMOB-27490