feat: support Xcode 12 #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
requested changes
Jun 22, 2020
cb1kenobi
requested changes
Jun 23, 2020
| @@ -144,6 +144,31 @@ const simulatorDevicePairCompatibility = { | |||
| '5.x': true, // watchOS 5.x | |||
| '6.x': true // watchOS 6.x | |||
| } | |||
| }, | |||
| '12.x': { // Xcode 12.x | |||
| '10.x': { // iOS 10.x | |||
There was a problem hiding this comment.
Xcode 12 does not appear to support anything older than iOS 10.3, so this should be '>=10.3 <11'.
| '>=3.2': true, // watchOS 3.2 | ||
| '4.x': true // watchOS 4.x | ||
| }, | ||
| '12.x': { // iOS 12.x |
There was a problem hiding this comment.
Xcode 12 allows you to pair watchOS 7 simulators with iOS 12 simulators, so this needs:
'7.x': true // watchOS 7.x
| '5.x': true, // watchOS 5.x | ||
| '6.x': true // watchOS 6.x | ||
| }, | ||
| '13.x': { // iOS 13.x |
There was a problem hiding this comment.
Xcode 12 allows you to pair watchOS 7 simulators with iOS 13 simulators, so this also needs:
'7.x': true // watchOS 7.x
| '5.x': true, // watchOS 5.x | ||
| '6.x': true // watchOS 6.x | ||
| }, | ||
| '14.x': { // iOS 14.x |
There was a problem hiding this comment.
Xcode 12 allows you to pair watchOS 4 simulators with iOS 14 simulators, so this needs:
'4.x': true // watchOS 4.x
|
Please take over this PR, I don't understand the feedback here. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #117