Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24773] Added support for Xcode 9, iOS 11, and watchOS 4. Updat… #58

Merged
merged 1 commit into from Jun 7, 2017
Merged

[TIMOB-24773] Added support for Xcode 9, iOS 11, and watchOS 4. Updat… #58

merged 1 commit into from Jun 7, 2017

Conversation

cb1kenobi
Copy link
Contributor

[TIMOB-24773] Added support for Xcode 9, iOS 11, and watchOS 4. Updated npm deps.

https://jira.appcelerator.org/browse/TIMOB-24773

@cb1kenobi cb1kenobi self-assigned this Jun 6, 2017
hansemannn
hansemannn approved these changes Jun 6, 2017
View reviewed changes
Copy link
Contributor

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + FT passed, tested with several (more complex) apps as well.

@cb1kenobi cb1kenobi removed the request for review from janvennemann June 6, 2017 22:10
janvennemann
janvennemann approved these changes Jun 7, 2017
View reviewed changes
Copy link

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, CR passed!

@hansemannn hansemannn merged commit c46817e into master Jun 7, 2017
@cb1kenobi cb1kenobi deleted the timob-24773 branch June 7, 2017 12:39
@ewieberappc ewieberappc self-requested a review June 7, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

@hansemannn hansemannn hansemannn approved these changes

@ewieberappc ewieberappc Awaiting requested review from ewieberappc

Assignees

@cb1kenobi cb1kenobi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cb1kenobi @janvennemann @hansemannn