[TIMOB-25309] Add support for Xcode 9's multiple simulator instances. #69
Conversation
lib/simulator.js
Outdated
| } | ||
| function waitToBoot() { | ||
| emitter.emit('log-debug', __('Waiting for sim to boot...')); | ||
| simctl.waitUntilBooted({ simctl: handle.simctl, udid: handle.udid, timeout: 30000 }, function (err, _booted) { |
There was a problem hiding this comment.
This reminds me of another thing we recently discussed: Might this be a good time to launch the Simulator earlier like some (..) other platforms do? Basically trigger it as soon as we get the UUID, so we won't have any delay for the initial launch anymore.
There was a problem hiding this comment.
We can't launch the simulator and then later install the app. ioslib's API isn't designed to do this. I can fix it, but I'd rather allocate the time towards ioslib v2 where I'll fix all these issues.
There was a problem hiding this comment.
Tested using the following scenarios:
- cold-launch on ios 11 sim (iphone 7) -> new boot
- recurring launch on ios 11 sim (iphone 7) -> reused
- recurring launch on ios 11 sim (iphone X) -> new boot
- recurring launch on ios 11 sim (iphone 7) -> reused
- recurring launch on ios 10.3 sim (iphone 5s) -> new boot
- recurring launch on ios 11 sim (iphone 7) -> reused
- recurring launch on ios 11 sim (iphone X) -> reused
- cold launch on ios 11 sim (iphone 7) -> reused
ALL worked perfect, really great work!
|
All instances of |
|
Can we agree on all |
|
|
|
Only talking about logs ^^ |
|
Oooooooh, that's cool. Is it OK if I tack it onto this PR quick? |
|
Of course :-D And guess we can merge here if you agree. |
|
@hansemannn Verbiage updated! :) |
|
Merging to get the show on the road. |
No description provided.