v1.7.14 #98
Merged
v1.7.14 #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Moved simctl and simulator executable definition from findSimulators() to detect() so that exact Xcode simctl path is coupled with each sim handle. refactor: Revamped sim runtime lookup and added a device type lookup which eliminated a 3rd level nested for loop and simplifies valid runtime resolution. fix: Fixed bug where non-iPhone, non-iPad, and non-Watch device types would be treated as watch devices and ultimately cause an error because Apple TV devices don't have a model number. refactor: Removed 'isAvailable' property added in PR #93 since the correct solution is not to track availability, but separate the selected Xcode from the Xcode associated with the requested simulator. fix: Added check to ensure watchCompanion cache only considers valid watchOS ranges. fix: Correct sort Xcodes in findSimulators() so that the iOS version takes precedence followed by the system selected Xcode and the latest version. fix: Select Xcode version based on specified iOS SDK version, system selected version, or latest version and don't worry about the version used to launch the simulator. style: Removed a handful of unused variables. fix: Fixed simulator device pair compatiblity lookup where >=4.x and >=3.2 would incorrectly include watchOS 5 and 6. chore: Updated npm deps within minor/patch ranges.
|
@cb1kenobi, I'm still seeing the problem stated in TIMOB-27338 with these changes. Repro steps:
Result: (you can switch the xcode versions, and pick iOS 13 and you'll see the same) Looking at the changes, we're still only running the simctl from the selected xcode, which as stated in the ticket is why we don't see the booted sim (it's not in that listing). |
ewanharris
requested changes
Sep 20, 2019
ewanharris
approved these changes
Sep 23, 2019
|
@cb1kenobi, as we're now running more simctl calls, might this be causing the timeouts on jenkins? Do you wanna try bumping those? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket: https://jira.appcelerator.org/browse/TIMOB-27338 and https://jira.appcelerator.org/browse/TIMOB-27397