Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-25072] Wait for server response without using "while loop" #106

Merged
merged 7 commits into from Sep 6, 2017
Merged

[TIMOB-25072] Wait for server response without using "while loop" #106

merged 7 commits into from Sep 6, 2017

Conversation

infosia
Copy link
Contributor

@infosia infosia commented Aug 15, 2017

TIMOB-25072

We don't want to wait for server response in while loop on Windows because it blocks networking operations. titanium_mobile_windows/pull/1075 introduces easier way to deal with it; new API only for Windows Ti.Network.HTTPClient._waitForResponse makes sure to wait for server response in order to get responseText and readyState in sync.

@infosia infosia changed the title [TIMOB-25072] Add waitForResponse() to wait for a response from server [TIMOB-25072] Wait for server response without using "while loop" Aug 15, 2017
@infosia
Copy link
Contributor Author

infosia commented Aug 28, 2017

@ewanharris Could you review & merge this? I'm wondering if we can push this in 6.2.0.RC along with https://github.com/appcelerator/titanium_mobile_windows/pull/1075.

@ewanharris
Copy link
Contributor

@infosia LiveView ships in Studio and as far as I know the next release is planned for September, I'll review it and then after the changes are merged to the Studio repo we can recommend Propelics use a nightly version of Studio

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure of the process for LiveView but...

FR Pass!

Alloy apps work consistently for me to ws-local, wp-emulator, and wp-device targets using

Appc CLI 6.2.4-master.9
Ti SDK 6.2.0.v20170901083635, 7.0.0.v20170901071732

@feons Do you know if I'm good to merge this, would you like to do a CR first?

@feons
Copy link
Contributor

feons commented Sep 5, 2017

@infosia, files under lib/platform are merged to produce build/liveview.js. Please include the changes here: https://github.com/feons/liveview/blob/master/lib/platform/require.js#L271.

@infosia
Copy link
Contributor Author

infosia commented Sep 6, 2017

@feons 👍 Fixed.

@feons
Copy link
Contributor

feons commented Sep 6, 2017

Approved.

@feons feons merged commit e1d5641 into tidev:master Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants