New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-25072] Wait for server response without using "while loop" #106
Conversation
@ewanharris Could you review & merge this? I'm wondering if we can push this in 6.2.0.RC along with https://github.com/appcelerator/titanium_mobile_windows/pull/1075. |
@infosia LiveView ships in Studio and as far as I know the next release is planned for September, I'll review it and then after the changes are merged to the Studio repo we can recommend Propelics use a nightly version of Studio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure of the process for LiveView but...
FR Pass!
Alloy apps work consistently for me to ws-local, wp-emulator, and wp-device targets using
Appc CLI 6.2.4-master.9
Ti SDK 6.2.0.v20170901083635, 7.0.0.v20170901071732
@feons Do you know if I'm good to merge this, would you like to do a CR first?
@infosia, files under |
@feons 👍 Fixed. |
Approved. |
TIMOB-25072
We don't want to wait for server response in
while
loop on Windows because it blocks networking operations. titanium_mobile_windows/pull/1075 introduces easier way to deal with it; new API only for WindowsTi.Network.HTTPClient._waitForResponse
makes sure to wait for server response in order to getresponseText
andreadyState
in sync.