Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not log ESRCH errors when stopping liveview #115

Merged
merged 1 commit into from Feb 27, 2020
Merged

fix: do not log ESRCH errors when stopping liveview #115

merged 1 commit into from Feb 27, 2020

Conversation

ewanharris
Copy link
Contributor

https://jira.appcelerator.org/browse/TIMOB-26267

h5.Steps to reproduce

  1. Create a liveview pid file with a pid that definitely doesn't exist touch ~/.titanium/123456789-liveview
  2. Run liveview server stop

No error should be logged with this change

@Dankyi Dankyi self-requested a review February 27, 2020 14:18
@ewanharris ewanharris changed the title [TIMOB-26267] Do not log ESRCH errors when stopping liveview fix: do not log ESRCH errors when stopping liveview Feb 27, 2020
Dankyi
Dankyi approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@Dankyi Dankyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR/FR pass

@Dankyi Dankyi merged commit 099cc1a into tidev:master Feb 27, 2020
@ewanharris ewanharris deleted the TIMOB-26267 branch February 27, 2020 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dankyi Dankyi Dankyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ewanharris @Dankyi