[TIMOB-13431] LiveView: iOS Simulator LiveView fails to build #12
Conversation
| @@ -9,7 +9,30 @@ var http = require('http') | |||
| , fs = require('fs') | |||
| , fsWatcher = require('chokidar') | |||
| , path = require('path') | |||
| , colors = require('colors'); | |||
There was a problem hiding this comment.
Comma first is not allowed! It violates our style guide.
There was a problem hiding this comment.
spoke with ingo he said it's fine for now in liveview we will revisit in planning week.
There was a problem hiding this comment.
Sorry, that's not what I meant. I mean, it should follow the JS guidelines now. If we want to change it as a group, we can do so in a discussion during planning week.
There was a problem hiding this comment.
@ingo ok I will fix 👎
There was a problem hiding this comment.
Oh pls don't change style convention to comma first!
There was a problem hiding this comment.
@jhaynie I only like it for module definitions
|
In testing I get this: |
|
Bad plugin hook error happens when the hook has a js syntax error. |
|
@bryan-m-hughes how are you installing ? |
|
@bryan-m-hughes the hook path is wrong it should be |
|
npm link/install should never be required to run a node.js project. It should always be possible to run directly. This absolutely needs to be fixed for 3.1.1. |
|
@bryan-m-hughes install/link is not required they just add and remove the hook for you if they are called. At minimum you will have to run |
|
@euforic in the future please say so. Also, my path was not wrong. |
|
Code reviewed and tested. Request accepted. |
[TIMOB-13431] LiveView: iOS Simulator LiveView fails to build
[TIMOB-13431] LiveView: iOS Simulator LiveView fails to build