Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): only read in strings.xml if it exists #121

Merged
merged 1 commit into from Feb 27, 2020
Merged

fix(i18n): only read in strings.xml if it exists #121

merged 1 commit into from Feb 27, 2020

Conversation

ewanharris
Copy link
Contributor

fixes TIMOB-26649

LiveViews assumption that a strings.xml file must exist if an i18n language dir exists appears to be incorrect, so before reading the file check that it actually exists/

@Dankyi Dankyi requested review from Dankyi and removed request for garymathews February 27, 2020 14:14
Copy link
Contributor

@Dankyi Dankyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR/FR passed

@Dankyi Dankyi merged commit 6a84338 into tidev:master Feb 27, 2020
@ewanharris ewanharris deleted the TIMOB-26649 branch March 6, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants