Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ignore connection refused error while reconnecting #170

Merged
merged 3 commits into from May 28, 2020
Merged

fix: ignore connection refused error while reconnecting #170

merged 3 commits into from May 28, 2020

Conversation

janvennemann
Copy link
Contributor

ewanharris
ewanharris reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR looks good, but I'm not sure whether we want to maybe show some form of "disconnected" screen, or even just allow this error through once?

Also, please run npm run build to make sure the updated built file gets updated and checked in

@janvennemann
Copy link
Contributor Author

I really don't like showing our big fat red error screen just for telling a user that liveview disconnected. An unobtrusive notification overlay would be really nice, but i didn't want to spent too much time on this so i just disabled showing anything in the app itself.

ewanharris
ewanharris approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair comment on the UI. We can move that another issue

@ewanharris ewanharris merged commit 5d7c76d into tidev:master May 28, 2020
@ewanharris ewanharris deleted the TIMOB-27832 branch May 28, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janvennemann @ewanharris