Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable alloy detection when webpack is active #171

Merged
merged 1 commit into from May 28, 2020
Merged

fix: disable alloy detection when webpack is active #171

merged 1 commit into from May 28, 2020

Conversation

janvennemann
Copy link
Contributor

@janvennemann janvennemann commented May 27, 2020 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-27907

Disables all special handling for Alloy when Webpack is active. Also disables processing with Babel, since Webpack already did that.

ewanharris
ewanharris approved these changes May 28, 2020
View reviewed changes
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR looks good!

@ewanharris ewanharris merged commit e7a862a into tidev:master May 28, 2020
@ewanharris ewanharris deleted the TIMOB-27907 branch May 28, 2020 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@janvennemann @ewanharris