fix(ios): add waitsForConnectivity to httpclient to allow local network prompt to be accepted #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk prompt to be accepted Part of TIMOB-28091
vijaysingh-axway
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
CR passed.
Note : PR tidev/titanium-sdk#11897 need to merge first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the absolute bare minimum needed to get liveview working on iOS 14. With this change we'll wait for the prompt to be accepted rather than crash (🎉 ). Currently there's 10 seconds to accept the prompt, after that liveview will timeout the connection itself (that's why I didn't add a setting for
timeoutIntervalForResource).We could probably improve that as a whole (not that it's a new improvement), but imo it's better to have a working liveview for now.
Part of TIMOB-28091