fix: use require function passed into wrapper #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulling from global isn't entirely correct as it will be lacking the correct context that helps perform the require algorithm, by using the require function passed in by the wrapper that context will exist allowing the require algorithm to work correctly Fixes TIMOB-28382
build
reviewed
Mar 12, 2021
lib/platform/require.js
Outdated
| * @param {string} id The module identifier | ||
| * @public | ||
| */ | ||
| export default function Module(id) { |
There was a problem hiding this comment.
⚠️ lib/platform/require.js line 1 – Import and export declarations are not supported yet. (node/no-unsupported-features/es-syntax)
|
sgtcoolguy
approved these changes
Mar 12, 2021
build
reviewed
Mar 12, 2021
lib/platform/require.js
Outdated
| * @param {string} id The module identifier | ||
| * @public | ||
| */ | ||
| export default function Module(id) { |
There was a problem hiding this comment.
⚠️ lib/platform/require.js line 2 – Import and export declarations are not supported yet. (node/no-unsupported-features/es-syntax)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling from global isn't entirely correct as it will be lacking the correct context that helps
perform the require algorithm, by using the require function passed in by the wrapper that context
will exist allowing the require algorithm to work correctly
Fixes TIMOB-28382