Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-23820] Liveview: on classic apps Hyperloop requires in app.js … #98

Merged
merged 2 commits into from Dec 9, 2016
Merged

[TIMOB-23820] Liveview: on classic apps Hyperloop requires in app.js … #98

merged 2 commits into from Dec 9, 2016

Conversation

feons
Copy link
Contributor

@feons feons commented Dec 9, 2016

…does not trigger metabase generation

https://jira.appcelerator.org/browse/TIMOB-23820

janvennemann
janvennemann requested changes Dec 9, 2016
View reviewed changes
Copy link
Contributor

@janvennemann janvennemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, no more errors when running Liveview with classic apps! Please add a version bump and i'll merge!

@feons
Copy link
Contributor Author

feons commented Dec 9, 2016

@janvennemann, bumped!

@feons feons merged commit 4ce9bf2 into tidev:master Dec 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janvennemann janvennemann janvennemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@feons @janvennemann