[TIMOB-24485] Revert TIMOB-23664 - Skip Windows virtual adapter #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@garymathews Do you think we want to pass it to |
|
I think we should mark for QE, since it could re-introduce https://jira.appcelerator.org/browse/TIMOB-23664 |
|
FR PASSED! Able to build a classic Titanium app for wp-emulator, ws-local, and wp-device targets. On wp-emulator, a user must pass in the ip of the Internal Switch Alloy app connects to server and fails on a file, will be fixed in: TIMOB-24699 Added TIDOC-2875 to review documentation to ensure it correctly reflects usage Windows platform (i.e. wp-emulator requiring --liveview-ip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TIMOB-24485
Revert #94 because this adapter may be used to communicate to emulators. From what I see on the latest Win 10 SDK & emulators this adapter is actually used. So I think under the variety of user's network configurations we should not skip specific interface automatically but should provide a way to select preferred interface to use - which is implemented in #96 (CLI-1075).