Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zip): support symlinks in zip files #283

Merged
merged 5 commits into from Sep 12, 2020
Merged

Conversation

sgtcoolguy
Copy link
Contributor

@sgtcoolguy sgtcoolguy commented Sep 11, 2020

This replaces usage of adm-zip with yauzl. It now supports retaining symlinks in extracted zips.

Note that any clients using the visitor function will get a different entry object shape in their args. From what I can tell none of the existing usage actually did anything with that arg, though.

I tested this locally by npm linking it into titanium cli and then re-installing an sdk with known symlinks: ./bin/titanium sdk install 9.2.0.v20200911073932

The progress bar rendered fine (no setTimeout hacks!), it retained the symlinks, and its appeared to be faster than before.

@build
Copy link

build commented Sep 11, 2020

Messages
📖

✅ All tests are passing
Nice one! All 220 tests are passing.

📖 🎉 - congrats on your new release

Dependencies removed: adm-zip.

New dependencies added: yauzl.

yauzl

Author: Josh Wolfe

Description: yet another unzip library for node

Homepage: https://github.com/thejoshwolfe/yauzl

Createdabout 6 years ago
Last Updatedabout 2 years ago
LicenseMIT
Maintainers2
Releases25
Direct Dependenciesfd-slicer and buffer-crc32
Keywordsunzip, zip, stream, archive and file
This README is too long to show.

Generated by 🚫 dangerJS against 52030b9

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested across mac and windows and everything is functioning ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants