fix(zip): support symlinks in zip files #283
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces usage of
adm-zip
withyauzl
. It now supports retaining symlinks in extracted zips.Note that any clients using the visitor function will get a different
entry
object shape in their args. From what I can tell none of the existing usage actually did anything with that arg, though.I tested this locally by
npm link
ing it into titanium cli and then re-installing an sdk with known symlinks:./bin/titanium sdk install 9.2.0.v20200911073932
The progress bar rendered fine (no
setTimeout
hacks!), it retained the symlinks, and its appeared to be faster than before.