[TIMOB-10767] Implemented support for working with modules #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
| }; | ||
|
|
||
| exports.find = function (modules, platforms, deployType, projectDir, logger, callback) { |
There was a problem hiding this comment.
Um, I sorta need this function. I pass it a list of modules from the tiapp.xml and it determines which ones are installed, missing, or incompatible.
There was a problem hiding this comment.
Where is it called from? I couldn't find it anywhere.
|
Yeah, I'm thinking this file should not have been touched at all. All this new activate module logic should be in the "titanium" repo in a module.js similar to config.js. |
|
I dunno, I don't like the idea of keeping related module logic in two different places. |
|
Code reviewed and tested. Request ACCEPTED. |
cb1kenobi
added a commit
that referenced
this pull request
Oct 5, 2012
[TIMOB-10767] Implemented support for working with modules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.