Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-24906] Android: Delay sending initial adb command #12

Merged
merged 2 commits into from Jun 30, 2017
Merged

[TIMOB-24906] Android: Delay sending initial adb command #12

merged 2 commits into from Jun 30, 2017

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jun 30, 2017 •
edited

  • Induce a 100ms delay before sending the initial ADB.exec() command
TEST CASE
  • Close all running emulators
  • Repeat run command a number of times
appc run -p android -T emulator
EXPECTED
  • Should not see error below, project should run on emulator
[ERROR] Failed to install apk on "emulator-5554"
[ERROR] Error: device not found
NOTE: this issue is commonly reproduced on Windows

JIRA Ticket

cb1kenobi
cb1kenobi approved these changes Jun 30, 2017
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. APPROVED

@cb1kenobi cb1kenobi merged commit 28b2f12 into tidev:master Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garymathews @cb1kenobi