Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsanalyze): handle when sourcemappingURL points to non-existent file #123

Merged
merged 3 commits into from Oct 11, 2019

Conversation

sgtcoolguy
Copy link
Contributor

@build
Copy link

build commented Oct 11, 2019

Fails
🚫 Tests have failed, see below for more information.
Messages
📖 ❌ 2 tests have failed There are 2 tests failing and 0 skipped out of 27 total tests.
📖 🎉 - congrats on your new release

Tests:

ClassnameNameTimeError
emulator lifecycle#isRunning() returns null object when not running30.147
Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/build/jenkins/workspace/cli_node-titanium-sdk_PR-123/tests/avd_test.js)
emulator lifecycle#start(), #isRunning() and #stop()30.149
Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/Users/build/jenkins/workspace/cli_node-titanium-sdk_PR-123/tests/avd_test.js)

Generated by 🚫 dangerJS against 099a32d

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR/FR. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants