Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): emulator fails to launch #136

Merged
merged 2 commits into from Jan 21, 2020
Merged

fix(android): emulator fails to launch #136

merged 2 commits into from Jan 21, 2020

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jan 21, 2020 •
edited

  • Emulator fails to launch as it's unable to find a valid port
  • Error code property error.errno should only return numeric values, error.code should be used instead
TEST CASE
  • Attempt to build Titanium application for emulator
  • Emulator should launch successfully and application will build

JIRA Ticket

@build
Copy link

build commented Jan 21, 2020 •
edited

Warnings
⚠️

lib/emulators/avd.js#L21 - lib/emulators/avd.js line 21 – Found require("child_process") (security/detect-child-process)
⚠️

lib/emulators/avd.js#L220 - lib/emulators/avd.js line 220 – 'err' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)
Messages
📖

✅ All tests are passing
Nice one! All 26 tests are passing.
📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against 2d508fa

jquick-axway
jquick-axway approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

cb1kenobi
cb1kenobi approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR'd, LGTM.

@garymathews garymathews merged commit e0249ea into tidev:master Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@jquick-axway jquick-axway jquick-axway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @cb1kenobi @jquick-axway