Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(android)(4_4_X): update android ndk folder detection #186

Merged
merged 6 commits into from Apr 13, 2020

Conversation

jquick-axway
Copy link
Contributor

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@build
Copy link

build commented Apr 13, 2020

Warnings
⚠️

lib/android.js#L62 - lib/android.js line 62 – Found non-literal argument in require (security/detect-non-literal-require)

⚠️

lib/android.js#L262 - lib/android.js line 262 – 'stderr' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L266 - lib/android.js line 266 – 'stderr' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L287 - lib/android.js line 287 – 'err' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L319 - lib/android.js line 319 – 'stderr' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L768 - lib/android.js line 768 – '+=' should be placed at the beginning of the line. (operator-linebreak)

⚠️

lib/android.js#L843 - lib/android.js line 843 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)

⚠️

lib/android.js#L844 - lib/android.js line 844 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)

⚠️

lib/android.js#L1104 - lib/android.js line 1104 – 'systemImages' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

Messages
📖

✅ All tests are passing
Nice one! All 26 tests are passing.

📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against d6b4b54

@jquick-axway jquick-axway merged commit cf46d9d into tidev:4_4_X Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants