[TIMOB-25742] Fixed adb issue where it fails to install to Android 4.1 devices #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndroid 4.1 devices
cb1kenobi
requested changes
Feb 2, 2018
lib/adb.js
Outdated
| } | ||
|
|
||
| // Set up the 'adb' arguments array. | ||
| let arguments = []; |
There was a problem hiding this comment.
arguments is a special word in JavaScript. Please use another variable name like args or something. Also, this should be const.
lib/adb.js
Outdated
| if (devices.filter(function (d) { return d.id == deviceId }).length != 1) return callback(new Error(__('device not found'))); | ||
|
|
||
| devices = devices.filter(function (d) { return d.id == deviceId }); | ||
| if (devices.length != 1) return callback(new Error(__('device not found'))); |
There was a problem hiding this comment.
In general, we prefer !== over !=. Same goes for the == on the previous line.
lib/adb.js
Outdated
| if (deviceApiLevel >= 17) { | ||
| // Set the '-d' argument to install an older APK over a new one. | ||
| // Note: Only supported on Android 4.2 (API Level 17) and higher. | ||
| arguments.push('-d'); |
There was a problem hiding this comment.
Why are we keeping the -d flag anyways? According to the adb help screen, it says "allow version code downgrade (debuggable packages only)". Do we care?
There was a problem hiding this comment.
I assume someone must have been burned by this at some point. Doesn't hurt to keep it. But I agree that this should be a rare event.
|
Updated PR based on feedback. |
cb1kenobi
approved these changes
Feb 2, 2018
|
APPROVED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-25742
Summary:
adb installcommand was passing argument-d, which is only supported on Android 4.2 and higher.-dargument if supported on device.Test:
Run the test attached to TIMOB-25742.