[TIMOB-26117] Use polyfill

[garymathews]

• Include babel-polyfil with Titanium builds
• Use babel-preset-minify
• Support async await

JIRA Ticket

• TIMOB-25802
• TIMOB-25740
• TIMOB-25816

[ewanharris]

According to the docs useBuiltIns doesn't take the entry/usage args in 6.X, only in 7.X. It's a boolean in 6.X

[garymathews]

Good catch

[ewanharris]

Seeing as we have the dependency added to the package.json, could we potentially copy it over to the app, it might have fewer potential problems that spawning npm

[garymathews]

This is what I was going to do initially, but I would need to manually copy over each dependency which could change. Where npm does this for us and keeps polyfill up-to-date.

Maybe it would be best to setup a symbolic link to polyfill? (on OSX anyway)

[sgtcoolguy]

First, I think it's important we install the exact version of polypill that is included/picked in the node-titanium-sdk install/dependency tree. As is, this will install the latest, which could be breaking.

[sgtcoolguy]

Second, I think this is a case where you'd want to use child_process.fork() since we really want to fork off another node process that is the same node install as currently being used. Obviously, that's an async API, so there's an issue there...

[sgtcoolguy]

Also, we discussed on Teams chat - but it may be better to just copy the babel-polyfill dependency tree over instead of doing an npm install. This could possibly achieve that: https://www.npmjs.com/package/copy-node-modules

[garymathews]

This will also allow support of async await

TEST CASE

const win = Ti.UI.createWindow({
        backgroundColor: 'gray'
    }),
    view = Ti.UI.createView({
        backgroundColor: 'red',
        width: 200,
        height: 200
    }),
    matrix = Ti.UI.create2DMatrix({
        rotate: 90
    }),
    animation = Ti.UI.createAnimation({
        transform: matrix,
        duration: 3000
    }),
    animate = (view, animation) => {
        return new Promise(resolve => view.animate(animation, resolve));
    };

win.addEventListener('postlayout', async () => {
    await animate(view, animation);
    view.backgroundColor = 'orange';
    alert('DONE ANIMATION!');
});

win.add(view);
win.open();

[sgtcoolguy]

So obviously this is much simpler than using npm install or that npm package I pointed at before about copying dependencies over. And it looks like for now this is comprehensive - but it does scare me for future maintenance that we're essentially hard-coding the known dependencies in an array here and not doing a more general solution that would adapt if the babel-polyfill dependencies changed in future releases.

I think at the very least we may want to leave a nice comment/scary notice here that that's exactly what we're doing and to be aware if updating babel-polyfill to look at/modify this logic.

[sgtcoolguy]

CR approved. LGTM

[sgtcoolguy]

Merged manually.