[TIMOB-26173] Add default Android Studio SDK install paths to lookup #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgtcoolguy
reviewed
Jul 6, 2018
lib/android.js
Outdated
| @@ -121,15 +121,15 @@ exports.detect = function detect(config, opts, finished) { | |||
|
|
|||
| // scan various paths | |||
| var dirs = process.platform === 'win32' | |||
| ? [ '%SystemDrive%', '%ProgramFiles%', '%ProgramFiles(x86)%', '%CommonProgramFiles%', '~' ] | |||
| : [ '/opt', '/opt/local', '/usr', '/usr/local', '~' ]; | |||
| ? [ '%SystemDrive%', '%ProgramFiles%', '%ProgramFiles(x86)%', '%CommonProgramFiles%', '~', '%LOCALAPPDATA%/Android' ] | |||
There was a problem hiding this comment.
Can this and the other copy of paths be extracted to a common method/constant? We're defining the exact same paths to look at in both cases, aren't we?
It also seems like maybe the sdk/ndk search against these paths should just happen once. I assume there's no easy way to combine them, though.
There was a problem hiding this comment.
Pushed the change to move the dirs out to a common constant. I'm not too sure on the sdk/ndk search, (to me) reading the code it makes more sense to have them separated and I don't think there'd be too much of a gain from searching once?
cb1kenobi
approved these changes
Jul 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-26173