Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(adb): check err.code instead of err.errno on socket error #431

Merged
merged 2 commits into from Jun 3, 2021
Merged

fix(adb): check err.code instead of err.errno on socket error #431

merged 2 commits into from Jun 3, 2021

Conversation

ewanharris
Copy link
Contributor

@ewanharris ewanharris commented Jun 3, 2021 •
edited

errno was removed in Node.js 13/14

Fixes TIMOB-28464

@build
Copy link

build commented Jun 3, 2021

Messages
📖 🎉 - congrats on your new release
📖

✅ All tests are passing
Nice one! All 26 tests are passing.

Generated by 🚫 dangerJS against 8d051c6

jquick-axway
jquick-axway approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

I tested launching Android emulator with node v12.13.0 on Big Sur.

@jquick-axway jquick-axway merged commit 6cf5094 into tidev:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewanharris @build @jquick-axway