Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): build on 64bit Linux fails if no 32bit libs available #442

Merged
merged 2 commits into from Jun 29, 2021

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-28496

Note:
The Android SDK's tools and emulator are 64-bit now. We no longer need to check for 32-bit libraries like this anymore.

Test:
Build and run a Titanium app project on 64-bit Linux to the Android emulator.

@build
Copy link

build commented Jun 25, 2021

Warnings
⚠️

lib/android.js#L62 - lib/android.js line 62 – Found non-literal argument in require (security/detect-non-literal-require)

⚠️

lib/android.js#L156 - lib/android.js line 156 – Empty block statement. (no-empty)

⚠️

lib/android.js#L216 - lib/android.js line 216 – Empty block statement. (no-empty)

⚠️

lib/android.js#L241 - lib/android.js line 241 – 'stderr' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L245 - lib/android.js line 245 – 'stderr' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L266 - lib/android.js line 266 – 'err' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L298 - lib/android.js line 298 – 'stderr' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/android.js#L702 - lib/android.js line 702 – '+=' should be placed at the beginning of the line. (operator-linebreak)

⚠️

lib/android.js#L777 - lib/android.js line 777 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)

⚠️

lib/android.js#L778 - lib/android.js line 778 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)

⚠️

lib/android.js#L1038 - lib/android.js line 1038 – 'systemImages' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

Messages
📖

✅ All tests are passing
Nice one! All 26 tests are passing.

Generated by 🚫 dangerJS against 91c263d

Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment about removing the file checks altogether

lib/adb.js Show resolved Hide resolved
Copy link
Contributor

@ewanharris ewanharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed look good to me!

@ewanharris ewanharris merged commit 59b1bb2 into tidev:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants