No longer require tooling that has been removed and/or is no longer referenced by the SDK build #467
Conversation
It no longer exists in API 31 tools
|
It looks to take at least 90 seconds for the emulator to start on github
lib/android.js
Outdated
| message += '\n'; | ||
| } | ||
| message += | ||
| __('Current installed Android SDK tools:') + '\n' |
There was a problem hiding this comment.
⚠️ lib/android.js line 781 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)
lib/android.js
Outdated
| message += '\n'; | ||
| } | ||
| message += | ||
| __('Current installed Android SDK tools:') + '\n' |
There was a problem hiding this comment.
⚠️ lib/android.js line 717 – '+=' should be placed at the beginning of the line. (operator-linebreak)
lib/android.js
Outdated
| message += '\n'; | ||
| } | ||
| message += | ||
| __('Current installed Android SDK tools:') + '\n' |
There was a problem hiding this comment.
⚠️ lib/android.js line 256 – 'stderr' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)
lib/android.js
Outdated
| message += '\n'; | ||
| } | ||
| message += | ||
| __('Current installed Android SDK tools:') + '\n' |
There was a problem hiding this comment.
⚠️ lib/android.js line 782 – Found non-literal argument to RegExp Constructor (security/detect-non-literal-regexp)
|
Jenkins failures were due to the emulator not being closed on the node. So the tests never called start, which dropped the coverage below the threshold |
|
@ewanharris, so I'm guessing our Maybe we close this PR (ie: keep the executable lookups we're doing) and just remove the exe checks in our titanium repo instead? This way older versions of the |
|
@jquick-axway, so that's for |
JIRA: https://jira.appcelerator.org/browse/TIMOB-28519
Removes the requirement for the dx tool (removed in the API 31 install) and the also removes the tools no longer directly referenced in the SDK build scripts.
This will need a follow up on the Titanium CLI repo to no longer as that checks that they exist in the
ti setup checkcommand, no breakage seen in Studio