Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-24736] Fix issue in minification of code #7

Closed
wants to merge 1 commit into from

Conversation

ewanharris
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-24736

This is a potential fix for the above, I dont think it is the right fix however as we will not be minifying code fully as we did before with uglify

@cb1kenobi
Copy link
Contributor

The bug TIMOB-24736 refers to is in Alloy, not Titanium Mobile or node-titanium-sdk.

@cb1kenobi cb1kenobi closed this May 26, 2017
@feons
Copy link
Contributor

feons commented May 26, 2017

@cb1kenobi, this PR turns babel-plugin-transform-inline-consecutive-adds off and prevents minifying step to fold assignment into object declaration.

var test = { a: 0, b:0, c:0 };
test.b = 1;

minified to:

var test={a:0,b:0,c:0,b:1};

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants