[TIMOB-24750] Only configure target platform #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
reviewed
May 30, 2017
lib/titanium.js
Outdated
| @@ -52,7 +52,8 @@ exports.commonOptions = function (logger, config) { | |||
| }; | |||
|
|
|||
| exports.platformOptions = function (logger, config, cli, commandName, finished) { | |||
| var result = {}; | |||
| var result = {}, | |||
| targetPlatform = cli.argv['platform'] || cli.argv['p']; | |||
There was a problem hiding this comment.
No need to reference these using brackets.
cb1kenobi
reviewed
May 30, 2017
lib/titanium.js
Outdated
| @@ -75,6 +76,12 @@ exports.platformOptions = function (logger, config, cli, commandName, finished) | |||
| // for each platform, fetch their specific flags/options | |||
| async.parallel(manifest.platforms.map(function (platform) { | |||
| return function (callback) { | |||
|
|
|||
| // only configure target platform | |||
| if (targetPlatform && platform != targetPlatform) { | |||
There was a problem hiding this comment.
Please use strict equality: !==.
cb1kenobi
requested changes
May 30, 2017
There was a problem hiding this comment.
This breaks the help command. If you do ti build -p ios --help, it does not display the complete help for the build command. You need to check if -h or --help was set. I'm not sure off the top of my head how this is treated. Maybe commandName is set to help? Maybe there's a boolean cli.argv.help? You'll have to poke around.
|
cb1kenobi
approved these changes
May 31, 2017
|
Looks good! APPROVED! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST CASE
windowsoriosNOTES: Unfortunately
cli.argv.platformis not defined at this point in the process