Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.0 [TIMOB-24884] Updated npm deps to fix babili minification erro… #9

Merged
merged 1 commit into from Jun 23, 2017

Conversation

cb1kenobi
Copy link
Contributor

[TIMOB-24884] Updated npm deps to fix babili minification error. Note that xmldom was not upgraded due to a bug in xmldom.

https://jira.appcelerator.org/browse/TIMOB-24884

…r. Note that xmldom was not upgraded due to a bug in xmldom.
@cb1kenobi cb1kenobi self-assigned this Jun 23, 2017
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Given that npm5 can do what yarn was doing for us, we may want to add a package-lock.json file too and eventually transition off yarn for this package now.

@sgtcoolguy sgtcoolguy merged commit c97cdc6 into tidev:master Jun 23, 2017
@cb1kenobi cb1kenobi deleted the timob-24884 branch June 23, 2017 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants