Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18137][TIMOB-18131]Tijscore update #19

Merged
merged 4 commits into from Dec 8, 2014

Conversation

vishalduggal
Copy link
Contributor

Fixes the following tickets
TIMOB-18137
TIMOB-18135
TIMOB-18118
TIMOB-18131

This PR does the following.
Removes dependency on WTF-iOS, JavaScriptCore-iOS and ToolExecutable-iOS xcconfig files

Modifies the message and stack properties on the ErrorInstance object to be enumerable so they can be grabbed on the Titanium side.

Disables the LLINT_C_LOOP execution model and enables JIT(DFG_JIT, FTL_JIT and YARR_JIT are still disabled)

There is also a new build script that builds WTF and JavaScriptCore on a per architecture basis so the logs the output to a text file so build errors are easy to track down.

We will be using our own configs. No dependency on WTF-iOS,
JavaScriptCore-iOS and ToolExecutable-iOS xcconfig files
Set default properties of stack and message properties to None so they
can be enumerated and retrieved on the Titanium side
Builds both WTF and JavaScriptCore on a per architecture basis and
writes out log files
@jonalter
Copy link
Contributor

jonalter commented Dec 8, 2014

CR & FT pass

Test code below

var Cloud = require('ti.cloud');

// Create a window
var win = Ti.UI.createWindow({
    backgroundColor : 'white',
    layout: 'vertical'
});
win.open();

addButton({
    title: 'null undefined',
    callback: function(e) {
        var result;
        if (result == null || result == undefined ) {
            console.log('YES');
        } else {
            console.log('NO');
        }
    }
});

addButton({
    title: 'null',
    callback: function(e) {
        var b = null;
        if (b != null) 
        { 
            // do something
            console.log('YES');
        } else {
            console.log('NO');
        }
    }
});

addButton({
    title: 'fail',
    callback: function(e) {
        var test = {};
        test.pipo();
    }
});

function addButton(params) {
    var button = Ti.UI.createButton({
        top: 40,
        title: params.title
    });
    button.addEventListener('click', function() {
        params.callback();
    });
    win.add(button);
}

jonalter added a commit that referenced this pull request Dec 8, 2014
[TIMOB-18137][TIMOB-18131]Tijscore update
@jonalter jonalter merged commit 41b985c into appcelerator-archive:v20 Dec 8, 2014
@vishalduggal vishalduggal deleted the timob-18137 branch December 8, 2014 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants