Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18208] Adding name mangling header to pass AppStore Validation #28

Merged
merged 1 commit into from Feb 12, 2015

Conversation

jonalter
Copy link
Contributor

@jonalter jonalter commented Feb 2, 2015

TIMOB-18208

Test case in ticket

@pec1985
Copy link
Contributor

pec1985 commented Feb 2, 2015

Code reviewed and library built successfully. Waiting for the Ingo's green flag to merge it

@pec1985
Copy link
Contributor

pec1985 commented Feb 12, 2015

Merging...

pec1985 added a commit that referenced this pull request Feb 12, 2015
[TIMOB-18208] Adding name mangling header to pass AppStore Validation
@pec1985 pec1985 merged commit 6a08df3 into appcelerator-archive:v20 Feb 12, 2015
@javenwang
Copy link

I received an error from Apple when I submit myapp:

Non-public API usage:

The app references non-public symbols in myapp: _WTFCrash, _WTFLogAlways, _WTFReportFatalError, _WebCoreWebThreadIsLockedOrDisabled

then I modified TiNameMangle.h to this:

#ifndef TiNameMangle_h
#define TiNameMangle_h

#define WTFCrash TiWTFCrash
#define WTFLogAlways TiWTFLogAlways
#define WTFReportFatalError TiWTFReportFatalError
#define WebCoreWebThreadIsLockedOrDisabled TiWebCoreWebThreadIsLockedOrDisabled

#endif

built and submited myapp again. This time only one non-public API left:

Non-public API usage:

The app references non-public symbols in myapp: _WTFCrash

any suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants