[TIMOB-17000] Fixed bug where integer config values were being saved …

…as strings instead of numbers.
tidev · May 20, 2014 · 3aae7ee · 3aae7ee
1 parent 99a0bbd
commit 3aae7ee
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,7 @@
  * Improved error handling when sdk command requests list of releases [TIMOB-16917]
  * Fixed bug with prompting for missing or invalid options that use generic prompting
  * Fixed sorting of Titanium SDKs in the 'sdk select' command to only list valid SDKs and order by their actual version number [TIMOB-16974]
+ * Fixed bug where integer config values were being saved as strings instead of numbers [TIMOB-17000]
 
 3.2.3 (5/1/2014)
 -------------------

diff --git a/lib/config.js b/lib/config.js
@@ -155,12 +155,15 @@ Object.defineProperty(config, 'set', {
 			} while (obj && (p = parts[i++]));
 		}
 
-		// if not an array, try to cast to null, true, false, or leave as string
+		// if not an array, try to cast to null, true, false, int or leave as string
 		if (!Array.isArray(value)) {
-			value = value == void 0 ? '' : value.toString().trim();
+			value = value === void 0 ? '' : String(value).trim();
 			value === 'null' && (value = null);
 			value === 'true' && (value = true);
 			value === 'false' && (value = false);
+			if (String(~~value) == value) {
+				value = ~~value;
+			}
 		}
 
 		if (obj && q) {