Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-17811] cli.sdk.platforms.iphone is undefined #165

Closed
wants to merge 1 commit into from

Conversation

yuchi
Copy link

@yuchi yuchi commented Oct 1, 2014

We check for cli.sdk.platforms.iphone before checking for .path.

This crashed a fresh Appcelerator Studio setup on Windows 7.

We check for `cli.sdk.platforms.iphone` before checking for `.path`
@ingo
Copy link
Contributor

ingo commented Oct 1, 2014

Thank you for this!

@yuchi yuchi changed the title Fixes TC-4823 — cli.sdk.platforms.iphone is undefined Fixes TC-4823/TIMOB-17811 — cli.sdk.platforms.iphone is undefined Oct 1, 2014
@yuchi yuchi changed the title Fixes TC-4823/TIMOB-17811 — cli.sdk.platforms.iphone is undefined [TIMOB-17811] cli.sdk.platforms.iphone is undefined Oct 1, 2014
@cb1kenobi
Copy link
Contributor

The root issue has been fixed already by ded5c83. Your fix would only be applicable in the scenario where you are on OS X and built Titanium SDK without iOS, which is not supported.

Thank you for the contribution. Closing as a dupe.

@cb1kenobi cb1kenobi closed this Oct 1, 2014
@yuchi
Copy link
Author

yuchi commented Oct 1, 2014

Don’t worry, my contribution was in fact a proposal made in a rush, solved the issue without knowledge of context.

Just as an information, that means that an OS X env needs an iOS configuration, even if I’m planning to work only (for instance) on Android?

@cb1kenobi
Copy link
Contributor

@yuchi You create have a Titanium app that does not support iOS. You won't have the default assets for iOS unless you specify it at the time the project is created and you're on a Mac.

I would like to fix this so that you can "create" a project on any platform for any number of platforms, but you simply cannot "build" the app unless your OS supports that platform.

On a side note, you will not have an official Titanium SDK release (for OS X) that does not include the Titanium iOS platform.

@yuchi
Copy link
Author

yuchi commented Oct 1, 2014

I would like to fix this so that you can "create" a project on any platform for any number of platforms, but you simply cannot "build" the app unless your OS supports that platform.

This was in fact one of those WAT? moments my first days on Ti. Would be awesome do decouple creation and build, at least on the CLI side. Studio will come along.

On a side note, you will not have an official Titanium SDK release (for OS X) that does not include the Titanium iOS platform.

I’m probably missing something, but that means that if I didn’t setup Xcode and iOS SDK at all, titanium will not work at all on OS X? I mean, never actually been on that situation myself, but it looks strange.

@cb1kenobi
Copy link
Contributor

@yuchi Regarding my second statement, I'm just saying that the Mac OS X version of the Titanium SDK will always come with the Titanium iOS platform files should you want to install Xcode and start building apps for iOS. You can still build apps the other platforms, though the same rules apply where Titanium SDK comes with Android, but you need the Android SDK. :)

@yuchi
Copy link
Author

yuchi commented Oct 1, 2014

Sorry I really blindly solved the issue today. What that method is doing is removing the hooks that manage xcode in older sdk, brutally rm them. Crystal clear now.

Thank you @cb1kenobi! You’re all doing a great work and I cannot express how much we appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants