[TIMOB-18161] CLI: Implement Java connectivity tests from titanium-connection-test in ti setup check #176
Conversation
… the windows.phone.publisherGuid value
| @@ -0,0 +1,15 @@ | |||
| [ | |||
| "https://api.appcelerator.com/p/v1/release-list", | |||
| "https://api.appcelerator.net/p/v1/release-list", | |||
There was a problem hiding this comment.
I don't think we would need api.appcelerator.net anymore.
Fix TIMOB-18344 CLI: the windows subcommand of ti setup should manage the windows.phone.publisherGuid value
| } else { | ||
| outObj = (out) ? JSON.parse(out.substr(out.indexOf("\n") + 1)) : {}; | ||
| if(!outObj.success) { | ||
| r.javaResults.push('dashboard.appcelerator.com'); |
There was a problem hiding this comment.
I don't quite understand why are we adding dashboard.appcelerator.com here and at the err condition. Doesn't Java executable return the list of unreachable hosts ?
There was a problem hiding this comment.
Ok, I decompiled and seen the contents of jar file, the whole purpose of this executable is we attempt to login into dashboard and if that fails, then add a note that the dashboard is not reachable.
|
CR and FR Passed. I can merge after addressing the build failure with Travis, and can you please squash the commits and force push one commit ? |
|
@pinnamur For what reason should @skypanther squash commits? I don't think that is necessary and I personally do not squash my own commits. Each commit tells a story. |
|
@cb1kenobi Our own guides ask contributors to squash commits. Single commits makes cherry picking easier. Each commit should leave the code in a functioning state to make git-bisect work correctly. Not squashing should be generally the exception rather than the rule. |
…nnection-test in ti setup check
skypanther
force-pushed
the
TIMOB-18161
branch
from
14fb1fc
to
319a56b
Compare
|
Crud, obviously I screwed up squashing the commits. |
https://jira.appcelerator.org/browse/TIMOB-18161