[TIMOB-18351] Deprecate iOS and Android modules in node-appc #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -446,6 +446,11 @@ SdkSubcommands.select = { | |||
| logger.error(__('Invalid Titanium SDK "%s"', value)); | |||
| return false; | |||
| } | |||
| if(parseInt(value.split('.').slice(0,3).join('')) < 320) { | |||
There was a problem hiding this comment.
You should use node-appc to do your version comparison:
if (appc.version.lt(value, '3.2.0')) {Also, make sure you have a space between if and the (. if is not a function.
| if (appc.version.lt(value, '3.2.0')) { | ||
| logger.log(''); | ||
| logger.warn(__('Selected SDK contains deprecated environment detection code.')); | ||
| logger.warn(__('Please choose a 3.2 or newer SDK for more accurate information.')); |
There was a problem hiding this comment.
The warning here needs to change. We shouldn't concern the user with detection code and such. We simply need to say:
Titanium SDK {VERSION} has been deprecated and will not work with future releases.
Please use Titanium SDK 3.2 or newer.
|
This commit also needs to include additional logic in the https://github.com/appcelerator/titanium/blob/master/hooks/tisdk3fixes.js file. In the |
|
CR passed. |
pinnamur
pushed a commit
that referenced
this pull request
Jan 27, 2015
[TIMOB-18351] Deprecate iOS and Android modules in node-appc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-18351