[TIMOB-17636] Create Titanium SDK folder if it doesn't exist #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1391,7 +1392,11 @@ SetupScreens.prototype.sdk = function sdk(callback) { | |||
| ignoreFiles: new RegExp(this._config.get('cli.ignoreFiles')), | |||
| validate: function (value) { | |||
| if (value && (!fs.existsSync(afs.resolvePath(value) || fs.statSync(value).isDirectory()))) { | |||
| throw new Error(__('Invalid directory')); | |||
| if (!fs.existsSync(afs.resolvePath(value))) { | |||
| wrench.mkdirSyncRecursive(value); | |||
There was a problem hiding this comment.
We might need to do a permissions check before we attempt to create a directory. Otherwise, users might end up something like this :
Path to find and install Titanium SDKs:
[/Users/pinnamuri/Library/Application Support/Titanium]: /Library/Application Support/Titanium
[ERROR] EACCES, permission denied '/Library/Application Support/Titanium'
There was a problem hiding this comment.
node-appc already has a function to check write permissions:
afs.isFileWritable(file);
afs.isDirWritable(dir);
|
CR and FR passed. |
pinnamur
pushed a commit
that referenced
this pull request
Jan 27, 2015
[TIMOB-17636] Create Titanium SDK folder if it doesn't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-17636