[TIMOB-18162] Autodetect proxy configuration within ti setup #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Line Interface, CLI version 3.6.0-dev, Titanium SDK version 3.6.0 Copyright (c) 2012-2014, Appcelerator, Inc. All Rights Reserved. Please report bugs to http://jira.appcelerator.org/ Enter ctrl-c at any time to quit. ──────────────────────┤ Main Menu ├─────────────────────── 1) �[36m�[1m�[4mq�[24m�[22m�[39muick Quick Setup 2) chec�[36m�[1m�[4mk�[24m�[22m�[39m Check Environment 3) �[36m�[1m�[4mu�[24m�[22m�[39mser User Information 4) a�[36m�[1m�[4mp�[24m�[22m�[39mp New App Defaults 5) �[36m�[1m�[4mn�[24m�[22m�[39metwork Network Settings 6) �[36m�[1m�[4mc�[24m�[22m�[39mli Titanium CLI Settings 7) �[36m�[1m�[4ms�[24m�[22m�[39mdk Titanium SDK Settings 8) �[36m�[1m�[4mi�[24m�[22m�[39mos iOS Settings 9) �[36m�[1m�[4ma�[24m�[22m�[39mndroid Android Settings 10) e�[36m�[1m�[4mx�[24m�[22m�[39mit Exit Where do you want to go?
| defaultProxy = this._config.get('cli.httpProxyServer'); | ||
| } else if(proxy.length > 0) { | ||
| var pI = 0, pL = proxy.length; | ||
| for(; pI < pL; pI++) { |
There was a problem hiding this comment.
can be just :
for(pI = 0; pI < proxy.length; pI++) {There was a problem hiding this comment.
except that then pI and pL would be global variables. I admit the form is a bit unusual but it follows the pattern of other code in the project.
There was a problem hiding this comment.
Typically I would just do:
for (var i = 0, len = proxy.length; i++) {
pI and pL are horrible names.
If you're feeling functional, you could do:
proxy.some(function (p) {
if (p && p.valid) {
defaultProxy = p.fullAddress;
console.log(defaultProxy);
return true;
}
});
|
merging.. |
sujmishra
pushed a commit
that referenced
this pull request
Feb 12, 2015
[TIMOB-18162] Autodetect proxy configuration within ti setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-18162