Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-18629] Changed the Node.js check from a hard range limit to a sof... #200

Merged
merged 1 commit into from Mar 3, 2015

Conversation

cb1kenobi
Copy link
Contributor

...t high version. So if the user is running a Titanium SDK that is not tested with Node.js 0.14, it will print a warning instead of error out.

…soft high version. So if the user is running a Titanium SDK that is not tested with Node.js 0.14, it will print a warning instead of error out.
@pinnamur
Copy link

pinnamur commented Mar 3, 2015

FR Passed.

The only problem I noticed is with the below configuration -

  • Node v0.12 is installed.
  • Selected Titanium SDK is 3.5.0.GA
  • Create a Titanium app with SDK set to 3.5.1.x and build the command using ti build -p ios

The above command will end abruptly while it tries to load node-ios-device libraries without any errors/warnings. However, if we we run the same command with the --sdk parameter, then it runs without any errors as expected.

pinnamur pushed a commit that referenced this pull request Mar 3, 2015
[TIMOB-18629] Changed the Node.js check from a hard range limit to a sof...
@pinnamur pinnamur merged commit a1becad into 3_4_X Mar 3, 2015
@cb1kenobi cb1kenobi deleted the timob-18629_3_4_X branch March 3, 2015 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants