Fix inconsistencies and invalid URL on ti setup check #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
reviewed
Jul 12, 2018
lib/commands/setup.js
Outdated
| @@ -669,6 +669,10 @@ SetupScreens.prototype.check = function check(callback) { | |||
| var cwd = process.mainModule && process.mainModule.filename, | |||
| root = path.resolve('/'); | |||
|
|
|||
| if (path.basename(cwd) === 'appc') { | |||
| cwd = require.resolve('titanium'); | |||
There was a problem hiding this comment.
Why can't you just do cwd = path.resolve(__dirname, '..', '..');?
There was a problem hiding this comment.
That makes more sense, and removes the need to even have this check. Updating
cb1kenobi
approved these changes
Jul 26, 2018
|
APPROVED |
|
@ewanharris Was this published so far? Trying with 5.1.1 and still see this issue. |
|
This fix has not been published yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-26206
https://jira.appcelerator.org/browse/TIMOB-24892