Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node appc #359

Merged
merged 3 commits into from Sep 12, 2020
Merged

Update node appc #359

merged 3 commits into from Sep 12, 2020

Conversation

ewanharris
Copy link
Contributor

As noted in #319 node-appc changes from iphone to ios so I've added something in to just set iphone to be super safe

@build
Copy link

build commented Sep 12, 2020

Warnings
⚠️

lib/commands/module.js#L96 - lib/commands/module.js line 96 – 'cli' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/module.js#L96 - lib/commands/module.js line 96 – 'config' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/module.js#L96 - lib/commands/module.js line 96 – 'logger' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

Messages
📖

✅ All tests are passing
Nice one! All 100 tests are passing.

📖 🎉 - congrats on your new release

Dependencies with modified semantic versioning:

Generated by 🚫 dangerJS against afdefec

@sgtcoolguy
Copy link
Contributor

Shouldn't node-appc be 1.1.0, not 1.0.1?

@ewanharris
Copy link
Contributor Author

Doh, of course. Updated to actually be the latest version!

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy sgtcoolguy merged commit 0b0284b into tidev:master Sep 12, 2020
@ewanharris ewanharris deleted the update_node-appc branch September 12, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants