Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local SDK zip installs #361

Merged
merged 2 commits into from Sep 14, 2020
Merged

Fix local SDK zip installs #361

merged 2 commits into from Sep 14, 2020

Conversation

ewanharris
Copy link
Contributor

@build
Copy link

build commented Sep 14, 2020

Warnings
⚠️

lib/commands/sdk.js#L106 - lib/commands/sdk.js line 106 – 'cli' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L106 - lib/commands/sdk.js line 106 – 'logger' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L106 - lib/commands/sdk.js line 106 – 'config' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L248 - lib/commands/sdk.js line 248 – Empty block statement. (no-empty)

⚠️

lib/commands/sdk.js#L344 - lib/commands/sdk.js line 344 – 'cli' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L384 - lib/commands/sdk.js line 384 – Empty block statement. (no-empty)

⚠️

lib/commands/sdk.js#L507 - lib/commands/sdk.js line 507 – 'cli' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L507 - lib/commands/sdk.js line 507 – 'config' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L507 - lib/commands/sdk.js line 507 – 'logger' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L872 - lib/commands/sdk.js line 872 – Found non-literal argument in require (security/detect-non-literal-require)

⚠️

lib/commands/sdk.js#L983 - lib/commands/sdk.js line 983 – 'cli' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L983 - lib/commands/sdk.js line 983 – 'config' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L983 - lib/commands/sdk.js line 983 – 'logger' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

⚠️

lib/commands/sdk.js#L1095 - lib/commands/sdk.js line 1095 – 'data' is defined but never used. Allowed unused args must match /^_.+/u. (no-unused-vars)

Messages
📖

✅ All tests are passing
Nice one! All 100 tests are passing.

📖 🎉 - congrats on your new release

Generated by 🚫 dangerJS against 27e4d5d

Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I should have caught this! I'd also love to drop adm-zip usage here entirely...

@sgtcoolguy sgtcoolguy merged commit 07da39a into tidev:master Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants